Stop stopping device detection interval #2646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Mar 23, 2017
lib/services/local-build-service.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| // import { exportedPromise } from "../common/decorators"; | |||
| // import { exported } from "../common/decorators"; | |||
There was a problem hiding this comment.
why are we updating the comment instead of removing it?
Delete @exportedPromise decorator as we no longer need it Stop stopping device detection interval when deploying on iOS devices. These operations no longer conflict as the code is located in an external dependency.
Mitko-Kerezov
force-pushed
the
kerezov/stop-stopping
branch
from
7cc3f75 to
6f8dcc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete @exportedPromise decorator as we no longer need it
Stop stopping device detection interval when deploying on iOS devices. These operations no longer conflict as the code is located in an external dependency.
Merge after telerik/mobile-cli-lib#917