Fix several issues in @next version
#2591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user tries to add invalid platform, CLI should prints user-friendly message. Instead it fails that cannot read `getPlatformData` of `undefined`. The reason is a change in platforms-data `getPlatformsData` method. Fix it to return undefined when there's no platform specific data. This way the code will detect the invalid platform and will fail with user-friendly message.
During adding of Android platform, users can specify targetSdk via `--sdk` command line option. This has been broken in previous commit. As our services should not rely on `$options`, sdk must be passed as parameter whenever it could be used. It turns out some common methods (addPlatform, preparePlatform) rely on platform specific data - sdk, provision, etc. In order to handle this without adding new arguments, introudce IPlatformSpecificData interface and use it in al methods where we have to pass some of the platform specific data required for preparing of the project.
In case you want to use `tns emulate android --release`, several android specific options should be passed and used by the service. Even when they are passed on the command line, we did not pass them to the service. Pass required options, so the release build will be successfully signed.
LiveSync provider that detects how to process the files, needs the projectData. However we had not passed it and the code fails. Pass the data wherever its needed. This fixes livesync operations.
rosen-vladimirov
requested review from
Plamen5kov,
dtopuzov,
Mitko-Kerezov and
TsvetanMilanov
dtopuzov
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit fixes different issue, so each commit can be checked on its own.
Fix adding of invalid platform
When user tries to add invalid platform, CLI should prints user-friendly
message. Instead it fails that cannot read
getPlatformDataofundefined. The reason is a change in platforms-datagetPlatformsDatamethod. Fix it to return undefined when there's no platform specific
data. This way the code will detect the invalid platform and will fail
with user-friendly message.
Fixes #2587
Fix specifiying --sdk on platform add
During adding of Android platform, users can specify targetSdk via
--sdkcommand line option. This has been broken in previous commit.As our services should not rely on
$options, sdk must be passed asparameter whenever it could be used. It turns out some common methods
(addPlatform, preparePlatform) rely on platform specific data - sdk,
provision, etc. In order to handle this without adding new arguments,
introudce IPlatformSpecificData interface and use it in al methods
where we have to pass some of the platform specific data required for
preparing of the project.
Fixes: #2588
Pass android specific options for emulate command
In case you want to use
tns emulate android --release, several androidspecific options should be passed and used by the service. Even when
they are passed on the command line, we did not pass them to the
service. Pass required options, so the release build will be
successfully signed.
Fixes: #2589
Fix livesync watch operations
LiveSync provider that detects how to process the files, needs the
projectData. However we had not passed it and the code fails. Pass the
data wherever its needed. This fixes livesync operations.
Fixes: #2590