Skip to content

[@next] tns platform add android --sdk <number> do not set targetSdkVersion in AndroidManifest.xml #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtopuzov opened this issue Mar 7, 2017 · 0 comments · Fixed by #2591
Closed

[@next] tns platform add android --sdk <number> do not set targetSdkVersion in AndroidManifest.xml #2588

dtopuzov opened this issue Mar 7, 2017 · 0 comments · Fixed by #2591
Assignees
@rosen-vladimirov
Labels
bug

Comments

@dtopuzov
Copy link
Contributor

dtopuzov commented Mar 7, 2017 •
edited
Loading 

tns create TNS_App
tns platform add android --path TNS_App --sdk 29

Result:
targetSdkVersion in TNS_App/platforms/android/src/main/AndroidManifest.xml is still 25.

Should be caused by: a008db1
@dtopuzov dtopuzov added the bug label Mar 7, 2017
@dtopuzov dtopuzov changed the title [@next] tns platform add android --sdk 29 do not set targetSdkVersion in AndroidManifest.xml [@next] tns platform add android --sdk <number> do not set targetSdkVersion in AndroidManifest.xml Mar 7, 2017
@rosen-vladimirov rosen-vladimirov self-assigned this Mar 7, 2017
@rosen-vladimirov rosen-vladimirov mentioned this issue Mar 7, 2017
Merged
@dtopuzov dtopuzov closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosen-vladimirov rosen-vladimirov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix several issues in @next version NativeScript/nativescript-cli
2 participants
@dtopuzov @rosen-vladimirov