-
-
Notifications
You must be signed in to change notification settings - Fork 197
Fixed: Livesync+Debug on Android not working when there are changes in tns-core-modules #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
15f0142
to
e72cc4f
Compare
|
||
let applicationId = deviceAppData.device.isEmulator ? projectData.projectName : deviceAppData.appIdentifier; | ||
let applicationId = deviceAppData.appIdentifier; | ||
if (deviceAppData.device.isEmulator && deviceAppData.platform.toLowerCase() === this.$devicePlatformsConstants.iOS.toLocaleLowerCase()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toLocaleLowerCase
-> toLowerCase
maybe
59092f0
to
27d6214
Compare
This is a functionality that needs to be tested (unit testing not integration). |
4b7124d
to
4d315a4
Compare
4d315a4
to
a44cf9f
Compare
@Plamen5kov |
With current code |
…android Fixed: Livesync+Debug on Android not working when there are changes in tns-core-modules
The issue:
Proposal:
In that situation we change only the js file and therefore it is not necessary to clean the whole build folder. We could check whether the change is in platforms folder of particular module. It so, we should clean the project. If not, it is safe to skip the clean process.