Skip to content

Commit 4d315a4

Browse files
author
Tsvetan Raikov
committed
Fixed: Livesync on Android is not working after changes in tns-core-modules
1 parent 4f9408a commit 4d315a4

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

lib/commands/debug.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
applicationId = projectData.projectName;
2424
}
2525
deviceAppData.device.applicationManager.stopApplication(applicationId).wait();
26-
26+
2727
this.debugService.debug().wait();
2828
}).future<void>()();
2929
};

lib/services/android-project-service.ts

+11-8
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
4141
private $devicePlatformsConstants: Mobile.IDevicePlatformsConstants,
4242
private $projectTemplatesService: IProjectTemplatesService,
4343
private $xmlValidator: IXmlValidator,
44+
private $config: IConfiguration,
4445
private $npm: INodePackageManager) {
4546
super($fs, $projectData, $projectDataService);
4647
this._androidProjectPropertiesManagers = Object.create(null);
@@ -405,16 +406,18 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
405406
}
406407

407408
public beforePrepareAllPlugins(): IFuture<void> {
408-
let buildOptions = this.getBuildOptions();
409-
buildOptions.unshift("clean");
409+
if (!this.$config.debugLivesync) {
410+
let buildOptions = this.getBuildOptions();
410411

411-
let projectRoot = this.platformData.projectRoot;
412-
let gradleBin = this.useGradleWrapper(projectRoot) ? path.join(projectRoot, "gradlew") : "gradle";
413-
if (this.$hostInfo.isWindows) {
414-
gradleBin += ".bat";
415-
}
416-
this.spawn(gradleBin, buildOptions, { stdio: "inherit", cwd: this.platformData.projectRoot }).wait();
412+
buildOptions.unshift("clean");
417413

414+
let projectRoot = this.platformData.projectRoot;
415+
let gradleBin = this.useGradleWrapper(projectRoot) ? path.join(projectRoot, "gradlew") : "gradle";
416+
if (this.$hostInfo.isWindows) {
417+
gradleBin += ".bat";
418+
}
419+
this.spawn(gradleBin, buildOptions, { stdio: "inherit", cwd: this.platformData.projectRoot }).wait();
420+
}
418421
return Future.fromResult();
419422
}
420423

test/npm-support.ts

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ function createTestInjector(): IInjector {
7878
testInjector.register("mobilePlatformsCapabilities", MobilePlatformsCapabilities);
7979
testInjector.register("devicePlatformsConstants", DevicePlatformsConstants);
8080
testInjector.register("xmlValidator", XmlValidator);
81+
testInjector.register("config", StaticConfigLib.Configuration);
8182

8283
return testInjector;
8384
}

test/plugins-service.ts

+2
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import {DeviceAppDataProvider} from "../lib/providers/device-app-data-provider";
3333
import {MobilePlatformsCapabilities} from "../lib/mobile-platforms-capabilities";
3434
import {DevicePlatformsConstants} from "../lib/common/mobile/device-platforms-constants";
3535
import { XmlValidator } from "../lib/xml-validator";
36+
import StaticConfigLib = require("../lib/config");
3637
import * as path from "path";
3738
import * as temp from "temp";
3839
temp.track();
@@ -99,6 +100,7 @@ function createTestInjector() {
99100
defaultTemplate: future.fromResult("")
100101
});
101102
testInjector.register("xmlValidator", XmlValidator);
103+
testInjector.register("config", StaticConfigLib.Configuration);
102104

103105
return testInjector;
104106
}

0 commit comments

Comments
 (0)