Validate drawable resources before building anything #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enchev
force-pushed
the
validate-android-drawable-resources
branch
2 times, most recently
from
6cffa50 to
61b8c26
Compare
| let drawableFilePrefix = "drawable-"; | ||
| let allowedDrawables = ["ldpi", "mdpi", "hdpi", "xhdpi", "xxhdpi", "xxxhdpi", "nodpi", "tvdpi"]; | ||
| let appSourceDirectoryPath = path.join(this.$projectData.projectDir, constants.APP_FOLDER_NAME); | ||
| let sourceAppResourcesDirectoryPath = path.join(appSourceDirectoryPath, constants.APP_RESOURCES_FOLDER_NAME); |
There was a problem hiding this comment.
isn't something missing here - the path will be <project dir>/app/App_Resources, while in fact you need Android dir if I'm not mistaken. Later you are using enumerateFilesInDirectorySync which will include all files from App_Resources, so you'll evalute any files/directories inside iOS dir as well.
I suggest adding Android platform in the path:
let sourceAppResourcesDirectoryPath = path.join(appSourceDirectoryPath, constants.APP_RESOURCES_FOLDER_NAME, this.$devicePlatformsConstants.Android);
enchev
force-pushed
the
validate-android-drawable-resources
branch
from
61b8c26 to
5b90a4e
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to fix #1296 :(
The result:
