-
-
Notifications
You must be signed in to change notification settings - Fork 197
tns build breaks permanately if you have drawable-invalid name #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Still valid in {N} 2.0.1. |
Try/Catch gradle spawn and suggest platform add/remove in case of error
Try/Catch gradle spawn and suggest platform add/remove in case of error
Hey @NathanaelA, What we can do in case of gradle build error is to suggest [UPDATE: I closed my pull request and will search for other options.] |
I've made second attempt to fix this. We will validate App_Resources drawable resources and we will stop the build in case of invalid. |
This comment was marked as abuse.
This comment was marked as abuse.
Hey @NathanaelA, In my opinion it will be better if we prevent the error at first place by validating resources. |
This comment was marked as abuse.
This comment was marked as abuse.
Hey @NathanaelA, Unfortunately we found that cannot handle this problem easily and I've removed the code that validates drawables. The other option will be to use our new clean command in such cases: |
I created a drawable-xdpi & drawable-xxxdpi (notice the missing H)
Well tns aborted the build and reported the first one was bad, and I realized I missed the h in both of them. So I added the missing h to both folder.. Tried to build again, still fails with the same bad folder name. But my copy isn't bad. However, tns still has the BAD folder names in the platform folder
platforms/android/src/main/res/ that you have to go manually delete before you can build again.
The text was updated successfully, but these errors were encountered: