Skip to content

tns build breaks permanately if you have drawable-invalid name #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanaelA opened this issue Dec 2, 2015 · 8 comments · Fixed by #1830
Closed

tns build breaks permanately if you have drawable-invalid name #1296

NathanaelA opened this issue Dec 2, 2015 · 8 comments · Fixed by #1830
Assignees
Milestone

Comments

@NathanaelA
Copy link
Contributor

I created a drawable-xdpi & drawable-xxxdpi (notice the missing H)
Well tns aborted the build and reported the first one was bad, and I realized I missed the h in both of them. So I added the missing h to both folder.. Tried to build again, still fails with the same bad folder name. But my copy isn't bad. However, tns still has the BAD folder names in the platform folder
platforms/android/src/main/res/ that you have to go manually delete before you can build again.

@teobugslayer teobugslayer added this to the 1.7.0 milestone Jan 27, 2016
@teobugslayer teobugslayer modified the milestones: 2.0, 1.7.0 Feb 18, 2016
@rosen-vladimirov rosen-vladimirov removed this from the 2.0 milestone Mar 31, 2016
@dtopuzov
Copy link
Contributor

dtopuzov commented Jun 7, 2016

Still valid in {N} 2.0.1.
Workaround: Delete your platform folder.

@enchev enchev self-assigned this Jun 10, 2016
enchev pushed a commit that referenced this issue Jun 10, 2016
Try/Catch gradle spawn and suggest platform add/remove in case of error
enchev pushed a commit that referenced this issue Jun 10, 2016
Try/Catch gradle spawn and suggest platform add/remove in case of error
@enchev
Copy link
Contributor

enchev commented Jun 10, 2016

Hey @NathanaelA,

What we can do in case of gradle build error is to suggest platform remove/add. Will this work for you? I've made pull request with this implemented.

[UPDATE: I closed my pull request and will search for other options.]

@enchev
Copy link
Contributor

enchev commented Jun 10, 2016

I've made second attempt to fix this. We will validate App_Resources drawable resources and we will stop the build in case of invalid.

@NathanaelA

This comment was marked as abuse.

@enchev
Copy link
Contributor

enchev commented Jun 13, 2016

Hey @NathanaelA,

In my opinion it will be better if we prevent the error at first place by validating resources. tns clean is another story and we will do our best to deliver it asap.

@NathanaelA

This comment was marked as abuse.

@enchev
Copy link
Contributor

enchev commented Jun 22, 2016

Hey @NathanaelA,

Unfortunately we found that cannot handle this problem easily and I've removed the code that validates drawables. The other option will be to use our new clean command in such cases:
tns platform clean android

@NathanaelA

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants