No debug break by default implementation added for iOS and Android #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enchev
changed the title
|
You should update help content and documentation as well (as I believe we are changing the default behavior of command). |
| this.startAppWithDebugger(packageFile, packageName).wait(); | ||
| //TODO: Find different way to make sure that the app is started. | ||
| sleep(500); | ||
| this.attachDebugger(device.deviceInfo.identifier, packageName).wait(); |
There was a problem hiding this comment.
maybe I'm totally missing something here, but shouldn't startAppWithDebugger do this... Based on it's name it looks like that's what it should do and we do not have to attach debugger again?
What's the case here?
|
👍 for the iOS changes, you may ping @slavchev to review the Android part. |
|
👍 |
| @@ -1,6 +1,9 @@ | |||
| debug android | |||
| ========== | |||
|
|
|||
| All you need to do to start debugging your app is to execute `tns debug android`. The NativeScript CLI will build, deploy, start your app, start Chrome DevTools and attach the debugger. | |||
There was a problem hiding this comment.
This should be under the Usage|Synopsis part of the help (here -> https://github.com/NativeScript/nativescript-cli/pull/1801/files#diff-e7b2eaa70b7b2394cb03e78ab260308aR18 ). We print the table of usage first in all of the help content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1376
When you call
tns debug ios|android(no--debug-brk) now we will build, deploy and start the application and attach the debugger. You can debug normally by placing breakpoint(s) in desired file(s). If you want to break somewhere initially you can usedebuggerkeyword in your code.The
--debug-brkswitch is still working as before in case you want to use it (not sure for what reason).