Skip to content

Consider removing --debug-brk parameter #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blagoev opened this issue Jan 6, 2016 · 3 comments
Closed

Consider removing --debug-brk parameter #1376

blagoev opened this issue Jan 6, 2016 · 3 comments
Assignees
@enchev
Labels
feature
Milestone
2.1

Comments

@blagoev
Copy link
Contributor

blagoev commented Jan 6, 2016

Neither --debug-brk nor --start option was specified. Defaulting to --debug-brk.

Since the android debug command is defaulting always to --debug-brk why do we have this parameter at all. Lets just remove this and have one thing less to worry about and show warning of.
@sitefinitysteve
Copy link

Agree
#1314

teobugslayer added a commit that referenced this issue Jan 7, 2016
@teobugslayer
Remove --debug-brk option
63dc05a 
See #1376
teobugslayer added a commit that referenced this issue Jan 8, 2016
@teobugslayer
Remove --debug-brk option
f143ca0 
See #1376
@teobugslayer
Copy link
Contributor

I started implementing this but I am blocked by a bug in the Karma launcher and cannot verify that my change does not break the unit testing. Once this is resolved, I'll create a PR with the fix.

@teobugslayer teobugslayer added this to the 1.6.0 milestone Jan 8, 2016
@blagoev
Copy link
Contributor Author

blagoev commented Jan 8, 2016

On the other hand if we want the functionality to be able to run an app in debug without breaking lets leave the parameter but remove the default setting.
ie tns debug android will run the app in debug without breaking on the first available statement.

@teobugslayer teobugslayer self-assigned this Jan 12, 2016
@teobugslayer teobugslayer modified the milestones: 1.7.0, 1.6.0 Feb 3, 2016
@teobugslayer teobugslayer modified the milestones: 2.0, 1.7.0 Feb 18, 2016
@sitefinitysteve sitefinitysteve mentioned this issue Mar 3, 2016
Closed
@rosen-vladimirov rosen-vladimirov modified the milestones: 2.1 (Under consideration), 2.0 Apr 18, 2016
@rosen-vladimirov rosen-vladimirov removed this from the 2.1 (Under consideration) milestone May 26, 2016
@enchev enchev self-assigned this Jun 3, 2016
@enchev enchev mentioned this issue Jun 3, 2016
Merged
@enchev enchev added this to the 2.1 (Under consideration) milestone Jun 3, 2016
@enchev enchev mentioned this issue Jun 3, 2016
Closed
@enchev enchev closed this as completed Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enchev enchev

Labels
feature
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
5 participants
@sitefinitysteve @blagoev @teobugslayer @enchev @rosen-vladimirov