Merge release in master #1664
Merged
Merge release in master #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to prevent double printing of stdout data, CLI mutes the stdout. However this is done in prompter constructor, so every class, that depends on the prompter, automatically mutes the stdout. Basically CLI mutes the stdout on almost all commands. This causes issues when `tns plugin add` command is used and the plugin wants to prompt the user for something on postinstall. Fix this by calling mute exactly before prompting the user and calling unmute immediately after user sends his answer.
Unmute stdout after prompter execution
Remove obsolete information and add references to setup scripts. Update docs for running ps1 setup script from within PowerShell in order to avoid problems with PowerShell Execution policies. Change .NET download link to a more robust one.
Update README.md
Changes include: * In case `ANDROID_HOME` environment variable is not set, try to determine the correct path to `android-sdk` through `android.bat`'s location * Use `android.bat` executable relative to `android-sdk`, set in `ANDROID_HOME` environment variable, for sdk updates * Split android sdk updates into single command calls in order to avoid problems with license agreements
Changes include: * In case `ANDROID_HOME` environment variable is not set, try to determine the correct path to `android-sdk` - either use homebrew's symlink or through `android` executable's location * Use `android` executable relative to `android-sdk`, set in `ANDROID_HOME` environment variable, for sdk updates * Split android sdk updates into single command calls in order to avoid problems with license agreements
Improve Setup Scripts' Android bits
Update CHANGELOG for 1.7.1
Update CHANGELOG for 1.7.1
There are some cases where updating tools requires updating platform-tools and if the former is attempted before the latter the following error is raised: `Skipping 'Android SKD Tools, revision 24.4.1'; it depends on 'Android SDK Platform-tools, revision 23.1 rc1' which was not installed` Fix this by reversing order
…ore-tools Install platform-tools before tools in setup scripts
Apply --baseConfig before replacing placeholders in manifest. This way when there are placeholders in the file passed as `--baseConfig`, they will be replaced correctly.
…-again Fix --baseConfig option
# Conflicts: # lib/common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release in master and update to latest common lib.