Fix --baseConfig option #1656
Merged
Fix --baseConfig option #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Let us integrate some more of this juicy {N} 😋 Please test for both Android and iOS. No need for WP for now. |
Apply --baseConfig before replacing placeholders in manifest. This way when there are placeholders in the file passed as `--baseConfig`, they will be replaced correctly.
rosen-vladimirov
force-pushed
the
vladimirov/fix-base-config-again
branch
from
b49d1c6 to
4014cd7
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply --baseConfig before replacing placeholders in manifest. This way when there are placeholders in the file passed as
--baseConfig, they will be replaced correctly.