Use spawn wherever possible #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -268,7 +268,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ | |||
| let project = this.createPbxProj(); | |||
| let frameworkName = path.basename(frameworkPath, path.extname(frameworkPath)); | |||
| let frameworkBinaryPath = path.join(frameworkPath, frameworkName); | |||
| let isDynamic = _.contains(this.$childProcess.exec(`otool -Vh ${frameworkBinaryPath}`).wait(), " DYLIB "); | |||
| let isDynamic = _.contains(this.$childProcess.exec(`otool -Vh "${frameworkBinaryPath}"`).wait(), " DYLIB "); | |||
There was a problem hiding this comment.
what if it already has "
ghost
force-pushed
the
kerezov/quote-framework
branch
2 times, most recently
from
37f5e73 to
0a61d4a
Compare
Mitko-Kerezov
changed the title
ghost
force-pushed
the
kerezov/quote-framework
branch
from
0a61d4a to
72b6965
Compare
Wherever possible use `spawn` instead of `exec`. This minifies the chance of something going wrong wherever there are spaces, quotation marks and whatnots in the project's name. Addresses #1455
|
👍 great |
Mitko-Kerezov
added a commit
that referenced
this pull request
Feb 8, 2016
Use spawn wherever possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wherever possible use
spawninstead ofexec.This minifies the chance of something going wrong wherever there are spaces, quotation marks and whatnots in the project's name.
Addresses #1455
Ping @rosen-vladimirov @teobugslayer