Skip to content

CLI not supporting a project path having a spaces #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nassimus26 opened this issue Feb 6, 2016 · 5 comments
Closed

CLI not supporting a project path having a spaces #1455

nassimus26 opened this issue Feb 6, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@nassimus26
Copy link

The -c otool -Vh /Volumes/VMware Shared Folders/dev/nativescript/gregories/ should be
-c otool -Vh /Volumes/VMware\ Shared\ Folders/dev/nativescript/gregories/

NMac:gregories nassimus$ tns livesync ios --emulator
nativescript-floatingactionbutton is not supported for ios.
The iOS Deployment Target is now 8.0 in order to support Cocoa Touch Frameworks in CocoaPods.
Successfully prepared plugin nativescript-iqkeyboardmanager for ios.
Successfully prepared plugin nativescript-social-share for ios.
Processing node_modules failed. Error: Command failed: /bin/sh -c otool -Vh /Volumes/VMware Shared Folders/dev/nativescript/gregories/node_modules/nativescript-telerik-ui/platforms/ios/TelerikUI.framework/TelerikUI
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: can't open file: /Volumes/VMware (No such file or directory)
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: can't open file: Shared (No such file or directory)
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: can't open file: Folders/dev/nativescript/gregories/node_modules/nativescript-telerik-ui/platforms/ios/TelerikUI.framework/TelerikUI (No such file or directory)

@nassimus26
Copy link
Author

this fix my issue

if (this.$fs.exists(projectFilePath).wait() && this.isProjectFileCorrect(projectFilePath)) {
            ->>> projectDir = projectDir.replace(/ /g, "\ ");
                    this.$logger.debug("Project directory is '%s'.", projectDir);
                    this.cachedProjectDir = projectDir;
                    break;
                }

the project preparation succeed but the build failed du to the boken path

@teobugslayer
Copy link
Contributor

I prefer quoting the strings where needed. At any rate, we will fix it. Thank you!

@teobugslayer
Copy link
Contributor

@vchimev, can we add integration tests with projects with spaces in key places?

@nassimus26
Copy link
Author

thanks, a lot i want to use the Vmware Shared Folder, and i didnt found how to change the default "Vmware Shared Folder" path, so i stuck for the moment

@teobugslayer
Copy link
Contributor

you can use your patch for the time being.

Mitko-Kerezov added a commit that referenced this issue Feb 8, 2016
It may contain spaces which fails when passed to the `otool`.
Addresses #1455
ghost pushed a commit that referenced this issue Feb 8, 2016
Wherever possible use `spawn` instead of `exec`.
This minifies the chance of something going wrong wherever there are spaces, quotation marks and whatnots in the project's name.
Addresses #1455
ghost pushed a commit that referenced this issue Feb 8, 2016
Wherever possible use `spawn` instead of `exec`.
This minifies the chance of something going wrong wherever there are spaces, quotation marks and whatnots in the project's name.
Addresses #1455
ghost pushed a commit that referenced this issue Feb 8, 2016
Wherever possible use `spawn` instead of `exec`.
This minifies the chance of something going wrong wherever there are spaces, quotation marks and whatnots in the project's name.
Addresses #1455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants