Merge Info.plist from App_Resources and plugins into platforms/ios #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanayotCankov
force-pushed
the
cankov/app-resources-info-plist
branch
from
2ff7349 to
ed0aace
Compare
|
Linter is failling: |
|
|
||
| // These got copied but are not actually resources. They should be rather filterd before the copy in the first place but anyway, let's just delete them here. | ||
| filterFile("Info.plist"); | ||
| // filterFile("Podfile"); |
There was a problem hiding this comment.
why are these lines commented? Please uncomment them or remove them
PanayotCankov
force-pushed
the
cankov/app-resources-info-plist
branch
3 times, most recently
from
ed448ee to
cf99858
Compare
Add an update route for when the Info.plist is missing in the template
PanayotCankov
force-pushed
the
cankov/app-resources-info-plist
branch
from
cf99858 to
66a55a9
Compare
|
👍 |
PanayotCankov
added a commit
that referenced
this pull request
Jan 7, 2016
…plist Merge Info.plist from App_Resources and plugins into platforms/ios
This was referenced Jan 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the #1089 for iOS.
If the file
app/App_Resources/iOS/Info.plistexists the new behavior is triggered, otherwise we should be backward compatible.On prepare we will get that
Info.plistand merge it with eachplatforms/ios/Info.plistfile from all plugins that have one. The CFBundleIdentifier will be set to package.json's nativescript.id and the result will be written toplatforms/ios/<proj-id>/<proj-id>-Info.plist.The App_Resources Info.plist has higher priority than the plugin Info.plists.
To use the new feature the hello-world template or the CLI will have to bring in a full blown
app/App_Resources/iOS/Info.plist.To be followed up by: