Skip to content

Allow Info.plist and AndroidManifest.xml files to be placed in App_Resources #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjvantoll opened this issue Oct 21, 2015 · 17 comments
Closed
Assignees
Milestone

Comments

@tjvantoll
Copy link
Contributor

To customize my iOS apps I frequently need to alter my Info.plist the file. If I place an appName-Info.plist file in App_Resources/iOS, the file gets copied to platforms/ios/appName/Resources, but it needs to be copied to platforms/ios/appName.

Can this be supported?

@tjvantoll
Copy link
Contributor Author

Actually I believe AndroidManifest.xml has the same problem.

@tjvantoll tjvantoll changed the title Allow Info.plist files in App_Resources/iOS Allow Info.plist and AndroidManifest.xml files to be placed in App_Resources Oct 21, 2015
@jlooper
Copy link

jlooper commented Oct 21, 2015

+1, this would be extremely helpful for both iOS and Android

@sitefinitysteve
Copy link

+1 it's painful to maintain important files in a volatile folder

@dapriett
Copy link

Support for custom Android build.gradle and iOS Podfiles would be nice too.

@toddanglin
Copy link

+1

I used XCode today to set a number of project settings (supported orientations, iOS devices, etc), so it would be great if these settings were more "durable" and easier to persist in source control (since the "platforms" folder is usually ignored). Especially when so many debugging/troubleshooting steps include "Delete your platforms ios/android directories." :)

@teobugslayer teobugslayer added this to the 1.6.0 (Under consideration) milestone Nov 4, 2015
@fritzvd
Copy link

fritzvd commented Nov 24, 2015

It's interesting that it does work when a plugin uses permissions such as @dapriett's https://github.com/dapriett/nativescript-google-maps-sdk

https://github.com/dapriett/nativescript-google-maps-sdk/blob/master/platforms/android/AndroidManifest.xml

These permissions do get added. Is there way to incorporate that same mechanism for the regular App_Resources files?

The merge of an xml (for android) is being handled in the plugin service..
https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/plugins-service.ts#L293

@ligaz
Copy link

ligaz commented Nov 26, 2015

The support for Android has landed in 1.5. This means that if you have an AndroidManifest.xml in App_Resources/Android it will be merged. The same goes for any resources in the App_Resources/Android/res.

@sitefinitysteve
Copy link

+10 for iOS support

@jlooper
Copy link

jlooper commented Dec 3, 2015

When can we expect this for iOS, please?

@sect2k
Copy link

sect2k commented Dec 4, 2015

Android support seems to be broken as well in 1.5.0. Adding AndroidManifest.xml to App_Resources, brakes the build step.

@ligaz
Copy link

ligaz commented Dec 8, 2015

@sect2k Maybe NativeScript/android#294 is the issue you have hit?

@sect2k
Copy link

sect2k commented Dec 10, 2015

@ligaz it seems the problem was this issue here NativeScript/android@cd51a51. After fixing the comma problem the build step runs fine, and seems to work.

@PanayotCankov
Copy link
Contributor

The #1369 just landed. With the next version of the CLI release an Info.plist will be created upon build or upon creating a new project in app/App_Resources/iOS/Info.plist and it will be merged with the Info.plist of the installed plugins. You can keep there build numbers and configure launch images, icons etc.

@speigg
Copy link

speigg commented Jan 22, 2016

Great. Is the Info.plist in app/App_Resources/iOS guaranteed to be merged last (after the info.plist of the installed plugins)? This is important for overriding settings that are provided by plugins (e.g., the nativescript-geolocation plugin).

@dragGH102
Copy link

+1 for plist merging for iOS

@PanayotCankov
Copy link
Contributor

@speigg: Yes, except for the bundle identifier that comes from the package.json.

@Daxito
Copy link

Daxito commented Jan 28, 2016

+1 for iOS support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests