Merge release in master pre 1.5.0 (third time) #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `karma-nativescript-launcher` we call startTestRunner through spawn. Communication between karma launcher and tns is through stdin. This is causing exception in buildMetadata step when gradle wrapper is used. For some reason it throws error in java code. So, replace the spawn with fork in the launcher. Modify `startTestRunner` to wait for message from parent process and send "ready" state to the parent. After that the parent (karma-nativescript-launcher) sends configuration data and the `startTestRunner` will execute the actions. Fixes #1199
As the current workflow of unit-testing is: 1) user calls `tns test android` 2) CLI starts a new process in which `tns dev-test android` is called 3) In case the dev-test command fails, the error is caught in the child process and command help is printed on the terminal directly in it. 4) User receives message: `Unable to find command dev-test|android` (from the child process) as we do not have help for this commands. Copy-paste the help fo test-android and test-ios commands and change the filenames so when the child process fails, it will print correct help. Parent process will not fail as the error is caught inside the child, so there's no way to print the help twice. Update common-lib to search dev-commands as well when searching for help pages.
In case node_modules dir is deleted, `tns test <platform>` command will fail. So ensure all dependencies are installed before starting karma server.
…unner Fix unit test runner on Windows
…r-run-command Release the console after `tns run ios` command
Fixes #1206
Fix ENOENT error when livesyncing deleted .xml or .css file
…dows Create configurations and src folders only for plugins that have native files
Bump ios-sim version
Shelljs likes to report some warnings, which we do not want to show to our users. So set it to silent mode by default. In case for any shelljs command you want to show the warnings, just set silent to false before executing it.
…definitions Silent shelljs by default
|
Test PASSed. |
…ivesync-command Show application output from livesync command
Conflicts: lib/common
rosen-vladimirov
force-pushed
the
vladimirov/merge-rel-master-pre-150-3
branch
from
2c3020d to
368044e
Compare
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 20, 2015
…r-pre-150-3 Merge release in master pre 1.5.0 (third time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.