Skip to content

Silent shelljs by default #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2015

Conversation

rosen-vladimirov
Copy link
Contributor

Shelljs likes to report some warnings, which we do not want to show to our users.
So set it to silent mode by default. In case for any shelljs command you want to show the warnings, just set silent to false before executing it.

This will also fix some warnings that are currently shown when preparing plugins. (cp - unable to find file...).

@rosen-vladimirov rosen-vladimirov self-assigned this Nov 19, 2015
@rosen-vladimirov rosen-vladimirov added this to the 1.5.0 milestone Nov 19, 2015
@ns-bot
Copy link

ns-bot commented Nov 19, 2015

Test PASSed.

@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/update-shelljs-definitions branch from e640c9f to ebc905f Compare November 19, 2015 21:29
@ns-bot
Copy link

ns-bot commented Nov 19, 2015

Test PASSed.

@teobugslayer
Copy link
Contributor

👍

Shelljs likes to report some warnings, which we do not want to show to our users.
So set it to silent mode by default. In case for any shelljs command you want to show the warnings, just set silent to false before executing it.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/update-shelljs-definitions branch from ebc905f to 9507f18 Compare November 20, 2015 07:17
@ns-bot
Copy link

ns-bot commented Nov 20, 2015

Test PASSed.

rosen-vladimirov added a commit that referenced this pull request Nov 20, 2015
@rosen-vladimirov rosen-vladimirov merged commit 441f927 into release Nov 20, 2015
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/update-shelljs-definitions branch November 20, 2015 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants