Add support for different templates #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| } | ||
|
|
||
| this.$logger.trace("New project package.json data: ", projectPackageJsonData); | ||
| this.$fs.writeJson(projectPackageJsonPath, projectPackageJsonData).wait(); |
There was a problem hiding this comment.
Should we delete the dependencies from template's package.json?
There was a problem hiding this comment.
Maybe it's better to delete template's package.json :)
There was a problem hiding this comment.
I've added code to delete the package.json from app dir
rosen-vladimirov
force-pushed
the
vladimirov/add-ns-templates
branch
from
40c3d1d to
c785049
Compare
|
Test PASSed. |
| this.$logger.out("Project %s was successfully created", projectName); | ||
|
|
||
| }).future<void>()(); | ||
| } | ||
|
|
||
| private mergeProjectAndTemplateProperties(projectDir: string, templatePath: string): IFuture<any> { |
There was a problem hiding this comment.
You are not returning but the return type is Future. Consider Future
rosen-vladimirov
force-pushed
the
vladimirov/add-ns-templates
branch
from
c785049 to
0edeec5
Compare
|
Test PASSed. |
|
💯 |
|
Test PASSed. |
|
👍 |
rosen-vladimirov
force-pushed
the
vladimirov/add-ns-templates
branch
from
56fbe6a to
df92027
Compare
|
Test PASSed. |
Add support for --template option when creating new project. The value for `--template` can be anything that you can `npm install`. For example valid calls are: * `tns create app1 --template tns-template-hello-world` * `tns create app1 --template https://github.com/NativeScript/template-hello-world-ts/tarball/master` * `tns create app1 --template ../myTemplate` In case you use: `tns create app1 --template typescript` or `tns create app1 --template tsc`, CLI will try to install `tns-template-hello-world-ts` template. In case you use `tns create app1 --template [email protected]` we will install version 1.2.0 of `tns-template-hello-world-ts`. When a custom template is used, CLI will extend its App_Resources with the ones from default template in case any of them is missing. Update npm version in order to support .git urls for --template option.
When `tns create <app>` is executed, install all dependencies, so typescript compilation will be enabled immediately when using tsc template.
rosen-vladimirov
force-pushed
the
vladimirov/add-ns-templates
branch
from
df92027 to
3ad7872
Compare
|
Test PASSed. |
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 30, 2015
Add support for different templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for --template option when creating new project.
The value for
--templatecan be anything that you cannpm install. For example valid calls are:tns create app1 --template tns-template-hello-worldtns create app1 --template https://github.com/NativeScript/template-hello-world-ts/tarball/mastertns create app1 --template ../myTemplatetns create app1 --template https://github.com/NativeScript/template-hello-world-ts.gittns create app1 --template https://github.com/NativeScript/template-hello-world-ts.git#masterIn case you use:
tns create app1 --template typescriptortns create app1 --template tsc, CLI will try to installtns-template-hello-world-tstemplate.In case you use
tns create app1 --template [email protected]we will install version 1.2.0 oftns-template-hello-world-ts.When a custom template is used, CLI will extend its App_Resources with the ones from default template in case any of them is missing.
Implements #374