Skip to content

Commit df92027

Browse files
Install all dependencies on create
When `tns create <app>` is executed, install all dependencies, so typescript compilation will be enabled immediately when using tsc template.
1 parent 0edeec5 commit df92027

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

lib/services/project-service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ export class ProjectService implements IProjectService {
8080
// Delete app/package.json file, its just causing confusion.
8181
// Also its dependencies and devDependencies are already merged in project's package.json.
8282
this.$fs.deleteFile(path.join(projectDir, constants.APP_FOLDER_NAME, constants.PACKAGE_JSON_FILE_NAME)).wait();
83+
this.$npm.install(projectDir, projectDir, { "ignore-scripts": this.$options.ignoreScripts }).wait();
8384
} catch (err) {
8485
this.$fs.deleteDirectory(projectDir).wait();
8586
throw err;

test/project-service.ts

-2
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ describe("Project Service Tests", () => {
187187
projectIntegrationTest.assertProject(tempFolder, projectName, "org.nativescript.myapp", projectTemplatesService.prepareTemplate("[email protected]").wait()).wait();
188188
});
189189

190-
/* Uncomment when tns-template-hello-world-ts is public
191190
it("creates valid project from typescript template", () => {
192191
let projectIntegrationTest = new ProjectIntegrationTest();
193192
let tempFolder = temp.mkdirSync("projectTypescript");
@@ -213,7 +212,6 @@ describe("Project Service Tests", () => {
213212
let projectTemplatesService: IProjectTemplatesService = projectIntegrationTest.testInjector.resolve("projectTemplatesService");
214213
projectIntegrationTest.assertProject(tempFolder, projectName, "org.nativescript.myapp", projectTemplatesService.prepareTemplate("tsc").wait()).wait();
215214
});
216-
*/
217215

218216
it("creates valid project from local directory template", () => {
219217
let projectIntegrationTest = new ProjectIntegrationTest();

0 commit comments

Comments
 (0)