Merge release in master pre 1.5.0 #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on lower than 1.5.0
…r-1.5+-runtime Don't try to execute fast livesync if the project has framework version lower than 1.5.0
As our hooks (like typescript) are called before executing prepare method, we must be sure we have all devDependencies installed in order to be able to execute before-prepare hooks. This is mandatory for projects where typescript is enabled, but you do not have node_modules directory yet.
Install devDependencies before prepare
The old fix for installing only devDependencies before preparing the project has a problem: `npm install <devPackagesNames>` does not respect the versions from the devDependencies section and always installs the latest versions. We cannot use `npm install <devPackageName>@<version>` as we do not know if they are real versions or paths or even "frog legs". There's a magical flag `--dev` which should allow you to do: `npm install <devPackagesNames> --dev` and it will respect the versions from devDependencies. Unfortunately this flag forces recursive installation of devDependencies all down the tree of packages. Of course npm has another rabbit in the hat - `--only=dev`. However I couldn't get it work at all. So the only solution I could think about is to install all dependencies before preparing the project.
Install ALL dependencies and devDependencies before prepare
…ings Collect all warnings upon pod installing
Get back the message that reports successful deploy on android device. We've deleted it a couple of commits ago.
|
Test PASSed. |
…success Show message after successful deploy on android
Set version to 1.6.0
rosen-vladimirov
force-pushed
the
vladimirov/merge-release-in-master-pre-150
branch
from
9d7a6b7 to
5b2bc76
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 16, 2015
…n-master-pre-150 Merge release in master pre 1.5.0
rosen-vladimirov
deleted the
vladimirov/merge-release-in-master-pre-150
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.