Collect all warnings upon pod installing #1188
Merged
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -524,7 +524,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ | |||
| // HACK for silencing irrelevant linking warnings when pod installing on | |||
There was a problem hiding this comment.
you do not need this comment anymore
|
Test PASSed. |
|
👍 |
Mitko-Kerezov
force-pushed
the
vladimirov/cocoa-pods-warnings
branch
from
6adac94 to
e3efe84
Compare
|
👍 after green build |
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 13, 2015
…ings Collect all warnings upon pod installing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover warnings printed on the stderr are considered errors and as a result fail the
$ tns prepare ioscommand. Make a more general regex for catching warnings.Ping @Mitko-Kerezov @Fatme