Always build --for-device with --release #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,7 +172,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ | |||
| } | |||
|
|
|||
| let args: string[] = []; | |||
| if(this.$options.forDevice) { | |||
| if(this.$options.forDevice || this.$options.release) { | |||
There was a problem hiding this comment.
You can extract this check to a separate variable and use it here and in the next if 😸
But definitely not a merge stopper
|
Test PASSed. |
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 9, 2015
Always build --for-device with --release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #945
Ping @Fatme @teobugslayer for a quick review