Skip to content

tns build --release should add --for-device #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjvantoll opened this issue Sep 18, 2015 · 6 comments
Closed

tns build --release should add --for-device #945

tjvantoll opened this issue Sep 18, 2015 · 6 comments
Assignees
Labels

Comments

@tjvantoll
Copy link
Contributor

I ran tns build ios --release for the first time today, and I was really surprised to find my .ipa in the platforms/ios/build/emulator folder.

If I'm doing a release build, shouldn't it be assumed that I'm building for a device and not emulators?

@tjvantoll
Copy link
Contributor Author

On top of this, currently, tns build ios --release does not show me where my .ipa was placed. However, tns build ios --release --for-device includes this very helpful message:

Results at '/Users/tj/Desktop/Groceries/platforms/ios/build/device/Groceries.ipa'
Project successfully built

@rosen-vladimirov
Copy link
Contributor

Hi @tjvantoll

Thanks for the feedback. I totally agree with you that release builds must target devices and we'll have to fix this behavior. I'll have to check why you do not see the path to the .ipa when producing release build. I consider both questions as issues in current implementation, so I've marked this as bug.

Thanks again!

@tjvantoll
Copy link
Contributor Author

Hey @rosen-vladimirov,

Thanks for the response. Just to note I do see the feedback when running tns build ios --release --for-device; I only do not see the path when I omit --for-device—aka tns build ios --release.

@Mitko-Kerezov
Copy link
Contributor

Hi @tjvantoll
We've decided against limiting users and instead sticking with the current behavior where any combination of --release, --debug, --for-device and --emulator is possible. Instead we've decided to implement a brand new command for performing publish builds which most probably generate an .xcarchive file and/or and .ipa file for ios.
Having that in mind the fix was reverted with this #1166

@tjvantoll
Copy link
Contributor Author

Thanks for the update @Mitko-Kerezov. I like the idea of having a new command because I think it’ll be easier for users to find, so 👍

@Mitko-Kerezov Mitko-Kerezov modified the milestones: 1.6.0 (Under consideration), 1.5.0 Nov 11, 2015
@teobugslayer teobugslayer removed this from the 1.6.0 milestone Feb 3, 2016
@teobugslayer
Copy link
Contributor

This will be addressed as part of #1172 , closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants