Do not call npm install if everything is installed #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there's node_modules dir and there's directory for each dependency defined in package.json of the project, we should not call `npm install`. In case `node_modules` dir does not exist and the project has dependencies or any of the dependencies is not installed, we'll call `npm install`. Another case when we'll call `npm install` is when `--force` option is used. This change is in order to allow modifications of modules inside `node_modules` directory.
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
|
👍 adding a unit test will be a nice addition. |
|
💯 |
In case CLI is version 1.4.x, on platform add we are trying to install latest available 1.4.x runtime. In case there's no 1.4.x version, the code fails. Instead we should install latest availabe version in this case.
rosen-vladimirov
force-pushed
the
vladimirov/do-not-install-every-time
branch
from
dda90f6 to
aa1ab49
Compare
|
Test PASSed. |
rosen-vladimirov
added a commit
that referenced
this pull request
Oct 26, 2015
…every-time Do not call npm install if everything is installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there's node_modules dir and there's directory for each dependency defined
in package.json of the project, we should not call
npm install. In casenode_modulesdirdoes not exist and the project has dependencies or any of the dependencies is not installed,
we'll call
npm install. Another case when we'll callnpm installis when--forceoption is used.This change is in order to allow modifications of modules inside
node_modulesdirectory.Second commit
Install latest available version if no matching version is found
In case CLI is version 1.4.x, on platform add we are trying to install latest available
1.4.x runtime. In case there's no 1.4.x version, the code fails.
Instead we should install latest available version in this case.