Install latest available version if no matching version is found

In case CLI is version 1.4.x, on platform add we are trying to install latest available
1.4.x runtime. In case there's no 1.4.x version, the code fails.
Instead we should install latest availabe version in this case.

Author: rosen-vladimirov

lib/npm-installation-manager.ts

@@ -84,7 +84,7 @@ export class NpmInstallationManager implements INpmInstallationManager {
 				.sortBy(verData => verData.patch)
 				.value();
 
-			let result = _.last(compatibleVersions);
+			let result = _.last(compatibleVersions) || this.getVersionData(latestVersion);
 
 			let latestCompatibleVersion = `${result.major}.${result.minor}.${result.patch}`;
 			return latestCompatibleVersion;

test/npm-installation-manager.ts

@@ -72,6 +72,7 @@ describe("Npm installation manager tests", () => {
 		let expectedLatestCompatibleVersion = "1.4.0";
 		assert.equal(actualLatestCompatibleVersion, expectedLatestCompatibleVersion);
 	});
+
 	it("returns correct latest compatible version", () => {
 		let testInjector = createTestInjector();
 
@@ -92,4 +93,23 @@ describe("Npm installation manager tests", () => {
 		let expectedLatestCompatibleVersion = "1.3.3";
 		assert.equal(actualLatestCompatibleVersion, expectedLatestCompatibleVersion);
 	});
+
+	it("returns correct latest compatible version", () => {
+		let testInjector = createTestInjector();
+
+		let versions = ["1.2.0", "1.3.0", "1.3.1", "1.3.2", "1.3.3", "1.4.0"];
+		let latestVersion = _.last(versions);
+		mockNpm(testInjector, versions, latestVersion);
+
+		// Mock staticConfig.version
+		let staticConfig = testInjector.resolve("staticConfig");
+		staticConfig.version = "1.5.0";
+
+		// Mock npmInstallationManager.getLatestVersion
+		let npmInstallationManager = testInjector.resolve("npmInstallationManager");
+		npmInstallationManager.getLatestVersion = (packageName: string) => Future.fromResult(latestVersion);
+
+		let actualLatestCompatibleVersion = npmInstallationManager.getLatestCompatibleVersion("").wait();
+		assert.equal(actualLatestCompatibleVersion, latestVersion);
+	});
 });