Skip to content

Implement a hard dependency on the node.js version and exit if not satisfied #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
valentinstoychev opened this issue Jun 26, 2015 · 1 comment
Closed

Implement a hard dependency on the node.js version and exit if not satisfied #594

valentinstoychev opened this issue Jun 26, 2015 · 1 comment
Assignees
@teobugslayer
Labels
feature
Milestone
1.5.0

Comments

@valentinstoychev
Copy link

We are currently logging a WARN when we run in an older version of Node.JS, but I think we need to stop the execution of the command if there is an older version of Node.js installed, otherwise some of the commands simply do not work. I hit an issues with the platform add command under Windows which prevented adding the Android platform at all. @rosen-vladimirov is aware of this.
@rosen-vladimirov rosen-vladimirov self-assigned this Jun 26, 2015
@teobugslayer teobugslayer added this to the 1.5.0 milestone Nov 3, 2015
teobugslayer added a commit that referenced this issue Nov 3, 2015
@teobugslayer
Verify node version and warn the user when it is not supported
24e5eb3 
Update node versions in package.json

Implements #594
@teobugslayer teobugslayer mentioned this issue Nov 3, 2015
Merged
@dtopuzov
Copy link
Contributor

dtopuzov commented Nov 6, 2015

With latest behavior we do WARN on each command if Node version is not in supported versions.

@dtopuzov dtopuzov closed this as completed Nov 6, 2015
@dtopuzov dtopuzov removed the 3 - Done label Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teobugslayer teobugslayer

Labels
feature
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
4 participants
@valentinstoychev @teobugslayer @dtopuzov @rosen-vladimirov