Skip to content

Commit 24e5eb3

Browse files
committed
Verify node version and warn the user when it is not supported
Update node versions in package.json Implements #594
1 parent c129e21 commit 24e5eb3

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

lib/common

lib/nativescript-cli.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
///<reference path=".d.ts"/>
22
"use strict";
3-
require("./bootstrap");
43

4+
// this call must be first to avoid requiring c++ dependencies
5+
require("./common/verify-node-version").verifyNodeVersion(require("../package.json").engines.node);
6+
7+
require("./bootstrap");
58
import fiber = require("fibers");
69
import Future = require("fibers/future");
710
import {installUncaughtExceptionListener} from "./common/errors";

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,6 @@
9898
},
9999
"license": "Apache-2.0",
100100
"engines": {
101-
"node": ">=0.10.26 <0.10.34 || >=0.10.35"
101+
"node": ">=0.10.40 <0.11.0 || >=0.12.7 <0.13.0 || >=4.2.1 <5.0.0"
102102
}
103103
}

0 commit comments

Comments
 (0)