Skip to content

fix(ios): remove VALID_ARCHS from cocoapods for xcode 12 #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 3, 2020

  • VALID_ARCHS cause problems with Xcode 12 due to the change mentioned in the Xcode 12 release notes [search for VALID_ARCHS - even though listed under Deprecations this appears to not totally be the case - it has been found that they cause broad reaching problems when present in building projects with Xcode 12]
  • This clears that value for any Cocoapods which may have that set and haven't yet removed it
  • We may want to release as 7.1.0 of cli since this would probably affect users building with Xcode 11.x still
  • Or the recommendation can be to use Xcode 12 with {N} 7 in general and release as 7.0.10 of cli

@cla-bot cla-bot bot added the cla: yes label Oct 3, 2020
@NathanWalker NathanWalker requested a review from rigor789 October 3, 2020 19:21
@rigor789 rigor789 merged commit 03ecac9 into master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants