Skip to content

fix(ios): remove VALID_ARCHS from cocoapods for xcode 12 #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2020
Merged

fix(ios): remove VALID_ARCHS from cocoapods for xcode 12 #5407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd55788
fix(ios): remove VALID_ARCHS from cocoapods for xcode 12
NathanWalker Oct 3, 2020
eb2c5e2
fix: tests
NathanWalker Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/services/cocoapods-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ ${versionResolutionHint}`);
const exclusions = `
post_install do |installer|
installer.pods_project.build_configurations.each do |config|
config.build_settings.delete "VALID_ARCHS"
config.build_settings["EXCLUDED_ARCHS_x86_64"] = "arm64 arm64e"
config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "i386 armv6 armv7 armv7s armv8 $(EXCLUDED_ARCHS_$(NATIVE_ARCH_64_BIT))"
config.build_settings["EXCLUDED_ARCHS[sdk=iphoneos*]"] = "i386 armv6 armv7 armv7s armv8 x86_64"
Expand Down
1 change: 1 addition & 0 deletions test/ios-project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ describe("Cocoapods support", () => {
`# Begin Podfile - ${projectPath}/platforms/ios/Podfile-exclusions`,
`def post_installNativeScript_CLI_Architecture_Exclusions_0 (installer)`,
` installer.pods_project.build_configurations.each do |config|`,
` config.build_settings.delete "VALID_ARCHS"`,
` config.build_settings["EXCLUDED_ARCHS_x86_64"] = "arm64 arm64e"`,
` config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "i386 armv6 armv7 armv7s armv8 $(EXCLUDED_ARCHS_$(NATIVE_ARCH_64_BIT))"`,
` config.build_settings["EXCLUDED_ARCHS[sdk=iphoneos*]"] = "i386 armv6 armv7 armv7s armv8 x86_64"`,
Expand Down