Skip to content

Commit 03ecac9

Browse files
authored
fix(ios): remove VALID_ARCHS from cocoapods for xcode 12 (#5407)
* fix(ios): remove VALID_ARCHS from cocoapods for xcode 12 * fix: tests
1 parent 78d0e73 commit 03ecac9

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

lib/services/cocoapods-service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ ${versionResolutionHint}`);
146146
const exclusions = `
147147
post_install do |installer|
148148
installer.pods_project.build_configurations.each do |config|
149+
config.build_settings.delete "VALID_ARCHS"
149150
config.build_settings["EXCLUDED_ARCHS_x86_64"] = "arm64 arm64e"
150151
config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "i386 armv6 armv7 armv7s armv8 $(EXCLUDED_ARCHS_$(NATIVE_ARCH_64_BIT))"
151152
config.build_settings["EXCLUDED_ARCHS[sdk=iphoneos*]"] = "i386 armv6 armv7 armv7s armv8 x86_64"

test/ios-project-service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ describe("Cocoapods support", () => {
268268
`# Begin Podfile - ${projectPath}/platforms/ios/Podfile-exclusions`,
269269
`def post_installNativeScript_CLI_Architecture_Exclusions_0 (installer)`,
270270
` installer.pods_project.build_configurations.each do |config|`,
271+
` config.build_settings.delete "VALID_ARCHS"`,
271272
` config.build_settings["EXCLUDED_ARCHS_x86_64"] = "arm64 arm64e"`,
272273
` config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "i386 armv6 armv7 armv7s armv8 $(EXCLUDED_ARCHS_$(NATIVE_ARCH_64_BIT))"`,
273274
` config.build_settings["EXCLUDED_ARCHS[sdk=iphoneos*]"] = "i386 armv6 armv7 armv7s armv8 x86_64"`,

0 commit comments

Comments
 (0)