You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):
CLI: 5.0.0-2018-10-11-12463
Cross-platform modules: rc
Describe the bug
If the version of some plugin in the package.json is specified with tag (f.e. rc) instead of version (f.e. 5.0.0), the tns preview command fails with:
TypeError: Cannot read property 'major' of null
at PreviewAppPluginsService.getWarningForPluginCore (/home/sis0k0/nativescript-cli/lib/services/livesync/playground/preview-app-plugins-service.ts:82:30)
The PreviewAppPluginsService uses semver to check some stuff with the versions of the plugins in the package.json. However, semver.coerce('rc') returns null and breaks the following logic.
Environment
Provide version numbers for the following components (information can be retrieved by running
tns info
in your project folder or by inspecting thepackage.json
of the project):Describe the bug
If the version of some plugin in the package.json is specified with tag (f.e.
rc
) instead of version (f.e.5.0.0
), thetns preview
command fails with:The
PreviewAppPluginsService
usessemver
to check some stuff with the versions of the plugins in the package.json. However,semver.coerce('rc')
returnsnull
and breaks the following logic.nativescript-cli/lib/services/livesync/playground/preview-app-plugins-service.ts
Lines 74 to 91 in b9bfc68
To Reproduce
tns preview
and scan the barcode.Expected behavior
To ignore the above check if the tag is
beta
,rc
ornext
.I can submit a PR if you agree that's the correct behaviour.
The text was updated successfully, but these errors were encountered: