fix(preview): skip check if local plugin version is invalid

If the local version of the plugin cannot be parsed by `semver`, the
check should be skipped and no warning shown.

fixes #4043

Author: sis0k0

lib/services/livesync/playground/preview-app-plugins-service.ts

@@ -74,20 +74,25 @@ export class PreviewAppPluginsService implements IPreviewAppPluginsService {
 	private getWarningForPluginCore(localPlugin: string, localPluginVersion: string, devicePluginVersion: string, deviceId: string): string {
 		this.$logger.trace(`Comparing plugin ${localPlugin} with localPluginVersion ${localPluginVersion} and devicePluginVersion ${devicePluginVersion}`);
 
-		if (devicePluginVersion) {
-			const localPluginVersionData = semver.coerce(localPluginVersion);
-			const devicePluginVersionData = semver.coerce(devicePluginVersion);
-
-			if (localPluginVersionData.major !== devicePluginVersionData.major) {
-				return util.format(PluginComparisonMessages.LOCAL_PLUGIN_WITH_DIFFERENCE_IN_MAJOR_VERSION, localPlugin, localPluginVersion, devicePluginVersion);
-			} else if (localPluginVersionData.minor > devicePluginVersionData.minor) {
-				return util.format(PluginComparisonMessages.LOCAL_PLUGIN_WITH_GREATHER_MINOR_VERSION, localPlugin, localPluginVersion, devicePluginVersion);
-			}
+		if (!devicePluginVersion) {
+			return util.format(PluginComparisonMessages.PLUGIN_NOT_INCLUDED_IN_PREVIEW_APP, localPlugin, deviceId);
+		}
 
+		const shouldSkipCheck = !semver.valid(localPluginVersion) && !semver.validRange(localPluginVersion);
+		if (shouldSkipCheck) {
 			return null;
 		}
 
-		return util.format(PluginComparisonMessages.PLUGIN_NOT_INCLUDED_IN_PREVIEW_APP, localPlugin, deviceId);
+		const localPluginVersionData = semver.coerce(localPluginVersion);
+		const devicePluginVersionData = semver.coerce(devicePluginVersion);
+
+		if (localPluginVersionData.major !== devicePluginVersionData.major) {
+			return util.format(PluginComparisonMessages.LOCAL_PLUGIN_WITH_DIFFERENCE_IN_MAJOR_VERSION, localPlugin, localPluginVersion, devicePluginVersion);
+		} else if (localPluginVersionData.minor > devicePluginVersionData.minor) {
+			return util.format(PluginComparisonMessages.LOCAL_PLUGIN_WITH_GREATHER_MINOR_VERSION, localPlugin, localPluginVersion, devicePluginVersion);
+		}
+
+		return null;
 	}
 
 	private hasNativeCode(localPlugin: string, platform: string, projectDir: string): boolean {

test/services/playground/preview-app-plugins-service.ts

@@ -243,6 +243,16 @@ describe("previewAppPluginsService", () => {
 					"nativescript-theme-core": "3.5.0"
 				},
 				expectedWarnings: []
+			},
+			{
+				name: "should not show warning when the local plugin version is tag",
+				localPlugins: {
+					"tns-core-modules": "rc"
+				},
+				previewAppPlugins: {
+					"tns-core-modules": "5.0.0"
+				},
+				expectedWarnings: <string[]>[]
 			}
 		];