Refactor args parsing and config management for connect and create_pool #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
reviewed
May 5, 2017
| @@ -625,8 +627,14 @@ def create_pool(dsn=None, *, | |||
| An :exc:`~asyncpg.exceptions.InterfaceError` will be raised on any | |||
| attempted operation on a released connection. | |||
| """ | |||
| if not issubclass(connection_class, connection.Connection): | |||
There was a problem hiding this comment.
We should add Connection to __init__, so that asyncpg.Connection is a thing.
1st1
force-pushed
the
args_rework
branch
3 times, most recently
from
1c8c2e0 to
b4da559
Compare
elprans
reviewed
May 5, 2017
asyncpg/connect_utils.py
Outdated
|
|
||
| if not addrs: | ||
| raise ValueError( | ||
| 'could not determine a list of database addresses to connect to') |
There was a problem hiding this comment.
s/a list of database addresses/the database address/
elprans
reviewed
May 5, 2017
asyncpg/connect_utils.py
Outdated
| not all(isinstance(v, str) for v in server_settings.values())): | ||
| raise ValueError( | ||
| 'server_settings is expected to be None or ' | ||
| 'a Mapping[str, str]') |
elprans
reviewed
May 5, 2017
tests/test_pool.py
Outdated
| @@ -351,6 +351,30 @@ class Error(Exception): | |||
| async with pool.acquire() as con: | |||
| await con.fetchval('SELECT 1') | |||
|
|
|||
| async def test_pool_config_persistance(self): | |||
Added: * `connection_class` parameter to connect() and create_pool() to specify a custom Connection object. * `server_settings` parameter to connect() and create_pool() to set custom server connection settings. Fixed: * Connection pool to always create Connections with correct configuration. Before, the pool could lose parameters like `statement_cache_size`. Backwards Compatibility: * connect() and create_pool() no longer accept arbitrary keyword arguments for server settings. Use new `server_settings` argument for that.
This was referenced May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
connection_classparameter to connect() and create_pool() tospecify a custom Connection object.
server_settingsparameter to connect() and create_pool() toset custom server connection settings.
Fixed:
configuration. Before, the pool could lose parameters like
statement_cache_size.Backwards Compatibility:
keyword arguments for server settings. Use new
server_settingsargument for that.