Skip to content

Missed connection parameters when reconnecting connection in PoolConnectionHolder #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lion34 opened this issue Apr 18, 2017 · 5 comments
Closed

Missed connection parameters when reconnecting connection in PoolConnectionHolder #125

Lion34 opened this issue Apr 18, 2017 · 5 comments
Labels
bug

Comments

@Lion34
Copy link

Lion34 commented Apr 18, 2017

PoolConnectionHolder.connect:
It seems that self._connect_kwargs is missed in self._pool._connect arguments when self._pool._working_addr is not None
@1st1
Copy link
Member

1st1 commented May 3, 2017

Yeah, that's intentional. Have you found any bugs caused by that?

@Lion34
Copy link
Author

Lion34 commented May 4, 2017

Yes, statement_cache_size=0 does not work when connection created from pool with defined working_addr.

@1st1 1st1 added bug and removed need more info labels May 4, 2017
@1st1
Copy link
Member

1st1 commented May 4, 2017

Then it's a bug. I'll look into it.

@1st1
Copy link
Member

1st1 commented May 5, 2017

PR #130 will fix this. 0.11.0 will be released soon.

@1st1 1st1 closed this as completed May 5, 2017
@1st1
Copy link
Member

1st1 commented May 12, 2017

0.11.0 has been released yesterday, please upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1st1 @Lion34