-
Notifications
You must be signed in to change notification settings - Fork 18
BLD Creates and test a source distribution #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thomasjpfan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM... untested.
azure/posix-sdist.yml
Outdated
anaconda -t $TOKEN upload --force -u $ANACONDA_ORG scikit-learn/dist/*.tar.gz | ||
echo "PyPI-style index: https://pypi.anaconda.org/$ANACONDA_ORG/simple" | ||
displayName: Upload to anaconda.org (only if secret token is retrieved) | ||
condition: ne(variables['TOKEN'], '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
posix.xml just has condition: variables['TOKEN']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM... untested.
In MacPython/numpy-wheels#78 I needed to mangle the
I think this is due to the bash shell equivalent being substandard on macOS, but was wondering if you ran into anything like this as well? |
In our case, we use a pretty long condition: scikit-learn-wheels/azure/posix.yml Line 114 in 8859f4f
to make sure not to update when the token is not defined. (Which I need to update this PR with) |
Now that we're releasing 0.23, should we merge this (after fixing the merge conflicts)? |
Note this PR places the (Did not want to have another |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thomasjpfan
Resolves #31
Cython needs to be installed for
0.22.X
sincepyproject.toml
is only on master and will be released with0.23
.CC @ogrisel