Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

BLD Creates and test a source distribution #53

Merged
merged 23 commits into from
May 12, 2020

Conversation

thomasjpfan
Copy link
Collaborator

Resolves #31

Cython needs to be installed for 0.22.X since pyproject.toml is only on master and will be released with 0.23.

CC @ogrisel

Copy link
Collaborator

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasjpfan

Copy link
Collaborator

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM... untested.

anaconda -t $TOKEN upload --force -u $ANACONDA_ORG scikit-learn/dist/*.tar.gz
echo "PyPI-style index: https://pypi.anaconda.org/$ANACONDA_ORG/simple"
displayName: Upload to anaconda.org (only if secret token is retrieved)
condition: ne(variables['TOKEN'], '')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posix.xml just has condition: variables['TOKEN']

Copy link
Collaborator

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM... untested.

@mattip
Copy link

mattip commented Apr 27, 2020

In MacPython/numpy-wheels#78 I needed to mangle the $TOKEN handling a little differently in order to get the non-uploading PRs (ones from a fork of this repo that have no access to the secrets) to respect the conditional upload, especially on macOS (not relevant for this PR). The steps were:

  • change the local secret-reflected name by adding the prefix MAPPED_
  • add another check if [ "$TOKEN" == "" -o "${TOKEN:0:7}" == "\$(NUMPY" ]; then ... because a missing secret resulted in $TOKEN having the value $(NUMPY_*_UPLOAD_TOKEN rather than ""

I think this is due to the bash shell equivalent being substandard on macOS, but was wondering if you ran into anything like this as well?

@thomasjpfan
Copy link
Collaborator Author

In our case, we use a pretty long condition:

condition: and(succeeded(), eq(variables['SKIP_BUILD'], 'false'), ne(variables['Build.Reason'], 'PullRequest'), variables['SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKEN'], variables['SCIKIT_LEARN_STAGING_UPLOAD_TOKEN'])

to make sure not to update when the token is not defined. (Which I need to update this PR with)

@adrinjalali
Copy link
Collaborator

Now that we're releasing 0.23, should we merge this (after fixing the merge conflicts)?

@thomasjpfan
Copy link
Collaborator Author

thomasjpfan commented May 11, 2020

Note this PR places the BUILD_COMMIT in azure-pipelines.yml, which means it is the only place we need to update to change the version.

(Did not want to have another BUILD_COMMIT in the sdist yaml.)

Copy link
Collaborator

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasjpfan

@adrinjalali adrinjalali merged commit b66b691 into MacPython:master May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a build for the source distribution
4 participants