Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

Add a build for the source distribution #31

Closed
jnothman opened this issue Jul 30, 2019 · 4 comments · Fixed by #53
Closed

Add a build for the source distribution #31

jnothman opened this issue Jul 30, 2019 · 4 comments · Fixed by #53

Comments

@jnothman
Copy link
Collaborator

It seems silly that:

  • the nightly builds do not include an sdist (to avoid users having to cythonize)
  • the release maintainer needs to build the sdist separate from the wheels.

We should have a job here that uploads an sdist alongside the wheels... as long as that then works with fetch_artifacts.

@rth
Copy link
Contributor

rth commented Jul 30, 2019

+1.

Do we still want to cythonize in sdists though? It's seems like Cython generated .c files is not forward compatible with future Python versions, and if I remember correctly there were several issues reported about it. Adding cython to build requirements (or what goes for it pre PEP 518) could be a workaround.

@ogrisel
Copy link
Contributor

ogrisel commented Oct 21, 2019

Good remark for Cython but this is a separate issue: we still have it if we do the sdist manually.

@ogrisel
Copy link
Contributor

ogrisel commented Mar 3, 2020

+1 for automating the generation of the sdist archive. That would also give us the ability to test installation from the source tarball. We could also run twine check on it.

@jnothman
Copy link
Collaborator Author

jnothman commented Mar 4, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants