Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

CI: Sync Minimum Versions #141

Merged
merged 4 commits into from
Jul 7, 2021
Merged

CI: Sync Minimum Versions #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4405113
Update azure-pipelines.yml
lithomas1 Jul 6, 2021
0958bfb
Update .travis.yml
lithomas1 Jul 6, 2021
d3b6171
Update posix.yml
lithomas1 Jul 6, 2021
2280f01
Update windows.yml
lithomas1 Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ env:
- BUILD_COMMIT="v1.3.0"
- UNICODE_WIDTH=32
- PLAT=aarch64
- NP_BUILD_DEP="numpy==1.16.5"
- NP_TEST_DEP="numpy==1.16.5"
- NP_BUILD_DEP="numpy==1.17.3"
- NP_TEST_DEP="numpy==1.17.3"
- CYTHON_BUILD_DEP="cython==0.29.21"
- WHEELHOUSE_UPLOADER_USERNAME=travis-worker
- TEST_DEPENDS="pytest pytest-xdist hypothesis"
Expand All @@ -25,8 +25,8 @@ jobs:
- os: linux
env:
- MB_PYTHON_VERSION=3.7
- NP_BUILD_DEP="numpy==1.16.5"
- NP_TEST_DEP="numpy==1.16.5"
- NP_BUILD_DEP="numpy==1.17.3"
- NP_TEST_DEP="numpy==1.17.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of lines below, we have NP_BUILD_DEP="numpy==1.19.1" for 3.8. Our min on master in pandas (i.e. 1,4) is 1.18.5. Any idea why there is a discrepancy there?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm. it's probably for the aarch support.

- os: linux
env:
- MB_PYTHON_VERSION=3.8
Expand Down
25 changes: 15 additions & 10 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ jobs:
py_3.7_32:
PYTHON_VERSION: "3.7"
PYTHON_ARCH: "x86"
NP_BUILD_DEP: "1.16.5"
NIGHTLY_BUILD: "true"
NP_BUILD_DEP: "1.17.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need to build 1.3.1, 1.3.2, .... etc

we won't be increasing min versions in patch releases, so this needs to reverted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.17.3 is the minimum version for 1.3.x though, but it wasn't bumped when the PR that released 1.3 was merged. This PR is just syncing the min versions with what is present on the main repo. See https://github.com/pandas-dev/pandas/blob/1.3.x/pyproject.toml for example which is supported by the docs link in the OP.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.17.3 is the minimum version for 1.3.x though

thanks. is this PR ready to merge. The failures are unrelated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Thanks for the quick reviews :).

# pandas 1.4 requires py3.8+, remove this job on 1.4 release
NIGHTLY_BUILD: "false"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing from nightly build though is fine.

py_3.7_64:
PYTHON_VERSION: "3.7"
PYTHON_ARCH: "x64"
NP_BUILD_DEP: "1.16.5"
NIGHTLY_BUILD: "true"
NP_BUILD_DEP: "1.17.3"
# pandas 1.4 requires py3.8+, remove this job on 1.4 release
NIGHTLY_BUILD: "false"
py_3.8_32:
PYTHON_VERSION: "3.8"
PYTHON_ARCH: "x86"
Expand Down Expand Up @@ -58,12 +60,14 @@ jobs:
py_3.7_32:
MB_PYTHON_VERSION: "3.7"
PLAT: "i686"
NP_BUILD_DEP: "numpy==1.16.5"
NIGHTLY_BUILD: "true"
NP_BUILD_DEP: "numpy==1.17.3"
# pandas 1.4 requires py3.8+, remove this job on 1.4 release
NIGHTLY_BUILD: "false"
py_3.7_64:
MB_PYTHON_VERSION: "3.7"
NP_BUILD_DEP: "numpy==1.16.5"
NIGHTLY_BUILD: "true"
NP_BUILD_DEP: "numpy==1.17.3"
# pandas 1.4 requires py3.8+, remove this job on 1.4 release
NIGHTLY_BUILD: "false"
py_3.8_32:
MB_PYTHON_VERSION: "3.8"
PLAT: "i686"
Expand Down Expand Up @@ -91,8 +95,9 @@ jobs:
matrix:
py_3.7_64:
MB_PYTHON_VERSION: "3.7"
NP_BUILD_DEP: "numpy==1.16.5"
NIGHTLY_BUILD: "true"
NP_BUILD_DEP: "numpy==1.17.3"
# pandas 1.4 requires py3.8+, remove this job on 1.4 release
NIGHTLY_BUILD: "false"
py_3.8_64:
MB_PYTHON_VERSION: "3.8"
NP_BUILD_DEP: "numpy==1.17.3"
Expand Down
2 changes: 1 addition & 1 deletion azure/posix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
REPO_DIR: "pandas"
BUILD_COMMIT: "v1.3.0"
PLAT: "x86_64"
NP_BUILD_DEP: "numpy==1.16.5"
NP_BUILD_DEP: "numpy==1.17.3"
CYTHON_BUILD_DEP: "cython==0.29.21"
NIGHTLY_BUILD_COMMIT: "master"
NIGHTLY_BUILD: "false"
Expand Down
2 changes: 1 addition & 1 deletion azure/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
vmImage: ${{ parameters.vmImage }}
variables:
BUILD_COMMIT: "v1.3.0"
NP_BUILD_DEP: "1.16.5"
NP_BUILD_DEP: "1.17.3"
CYTHON_BUILD_DEP: "0.29.21"
NIGHTLY_BUILD_COMMIT: "master"
NIGHTLY_BUILD: "false"
Expand Down