CI: Sync Minimum Versions #141
Conversation
| @@ -22,13 +22,15 @@ jobs: | |||
| py_3.7_32: | |||
| PYTHON_VERSION: "3.7" | |||
| PYTHON_ARCH: "x86" | |||
| NP_BUILD_DEP: "1.16.5" | |||
| NIGHTLY_BUILD: "true" | |||
| NP_BUILD_DEP: "1.17.3" | |||
There was a problem hiding this comment.
we still need to build 1.3.1, 1.3.2, .... etc
we won't be increasing min versions in patch releases, so this needs to reverted.
There was a problem hiding this comment.
1.17.3 is the minimum version for 1.3.x though, but it wasn't bumped when the PR that released 1.3 was merged. This PR is just syncing the min versions with what is present on the main repo. See https://github.com/pandas-dev/pandas/blob/1.3.x/pyproject.toml for example which is supported by the docs link in the OP.
There was a problem hiding this comment.
1.17.3 is the minimum version for 1.3.x though
thanks. is this PR ready to merge. The failures are unrelated?
There was a problem hiding this comment.
Yep. Thanks for the quick reviews :).
| NIGHTLY_BUILD: "true" | ||
| NP_BUILD_DEP: "1.17.3" | ||
| # pandas 1.4 requires py3.8+, remove this job on 1.4 release | ||
| NIGHTLY_BUILD: "false" |
There was a problem hiding this comment.
removing from nightly build though is fine.
| - NP_BUILD_DEP="numpy==1.16.5" | ||
| - NP_TEST_DEP="numpy==1.16.5" | ||
| - NP_BUILD_DEP="numpy==1.17.3" | ||
| - NP_TEST_DEP="numpy==1.17.3" |
There was a problem hiding this comment.
a couple of lines below, we have NP_BUILD_DEP="numpy==1.19.1" for 3.8. Our min on master in pandas (i.e. 1,4) is 1.18.5. Any idea why there is a discrepancy there?
There was a problem hiding this comment.
nvm. it's probably for the aarch support.
|
Thanks @lithomas1 |
https://pandas.pydata.org/docs/getting_started/install.html#dependencies
cc @simonjayhawkins