Added @Keep annotations for CoroutineExceptionHandler and MainDispatсherFactory which are loaded via ServiceLoader.load() on Android. #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…herFactory which are loaded via ServiceLoader.load() on Android.
|
Does this PR work for Kotlin/JS? |
|
Hm, it seems, |
|
You need to define an @OptionalExpecation expect annotation named Keep in the common code and then actual typealias it to the real annotation in the JDK code. |
|
The PR is on the core module, so it is not possible to import the Moreover this PR does not include the imports. |
|
Hence my comment which shows you how to do it correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android app crashes in runtime when obfuscated with default Proguard settings. This PR adds
@Keepannotation for two classes which are located viaServiceLoader.load().