Android app with coroutines 0.30.1-eap13 crashes in runtime

[trashkalmar]

java.lang.IllegalStateException: Module with Main dispatcher is missing. Add dependency with required Main dispatcher, e.g. 'kotlinx-coroutines-android'
        at kotlinx.coroutines.Dispatchers.getMain(Dispatchers.kt:61)

kotlinx-coroutines-android is obviously added.
Version 0.30.0-eap13 works fine.

[qwwdfsad]

Could you please provide a self-contained example? Or check why loadMainDispatcher loads nothing?

[trashkalmar]

Could you please provide a self-contained example?

It is enough to start any coroutine in UI context. For example:
GlobalScope.launch(Dispatchers.Main) { ... }

Or check why loadMainDispatcher loads nothing?

ServiceLoader is unable to load MainDispatcherFactory.

[qwwdfsad]

It is enough to start any coroutine in UI context.

I did it in sample Android project and it works in both debug and release mode.

ServiceLoader is unable to load MainDispatcherFactory.

Again, works on my machine.

Please be cooperative. I'm willing to help you, but I can't do anything with reports like "it doesn't work"

[trashkalmar]

It was my fault. I've excluded some Kotlin meta files from APK (specifically, Meta-inf/services/**). It was safe for previous coroutines version, but for 0.30.1 it became destructive.
Sorry that wasted your time.

[trashkalmar]

If an app is obfustacted with default proguard settings, it crashes in runtime. Here is sample project to reproduce an issue: https://www.dropbox.com/s/eay696h9qmxjl5e/sample.zip?dl=1
UPD: I've created PR #662 but it will not work, because @Keep annotation is Android specific.
Is the only way to add proguard rules?

-keepnames class kotlinx.coroutines.CoroutineExceptionHandler {}
-keepnames class kotlinx.coroutines.internal.MainDispatcherFactory {}

[ghost]

I had this bug when exported file apk when using proguard with the version 0.30.2.

[petitJAM]

Those proguard rules didn't work for me, so I used this:

-keepnames class kotlinx.** { *; }

Definitely not a great solution since it tells proguard to keep everything, but it works.

[bernaferrari]

Same issue here with 0.30.2.

[jvlad]

The same issue with 0.30.1 in release build only (i. e. when minifyEnabled true is specified)

Android Studio 3.1.2
Build #AI-173.4720617, built on April 14, 2018
JRE: 1.8.0_152-release-1024-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.13.4

Didn't work:

-keepnames class kotlinx.coroutines.CoroutineExceptionHandler {}
-keepnames class kotlinx.coroutines.internal.MainDispatcherFactory {}

Worked:

-keepnames class kotlinx.** { *; }

[qwwdfsad]

Thank you @trashkalmar for the reproducer.
Jettifier seems to have an issue with ServiceLoader and name mangling.

I have (ugly as hell) fix which first tries to lookup main dispatcher in service loader and then invokes Class.forName("...") for android factory. It will be fixed in 1.0.0-RC

[bernaferrari]

This happens to me even without jetfier. Just proguard on its enough.

[AAverin]

It would be great if kotlinx.coroutines library could include proguard rules as part of distribution

[bernaferrari]

@AAverin There is already, isn't it?
https://github.com/Kotlin/kotlinx.coroutines/blob/master/core/kotlinx-coroutines-core/resources/META-INF/proguard/coroutines.pro

[AAverin]

@bernaferrari then they need to be updated to

-keepnames class kotlinx.** { *; }

for kotlinx-coroutines-android

[JakeWharton]

Why?

…

On Mon, Oct 22, 2018, 5:10 AM Anton Averin ***@***.*** wrote: @bernaferrari <https://github.com/bernaferrari> then they need to be updated to -keepnames class kotlinx.** { *; } for kotlinx-coroutines-android — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#657 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEESZtvZwmEJ_6n71AW3dhWe-e3j4cks5unYt6gaJpZM4XFs_r> .

[ghost]

I have the same issue with 0.30.2

I also get default rule at
https://github.com/Kotlin/kotlinx.coroutines/blob/master/core/kotlinx-coroutines-core/resources/META-INF/proguard/coroutines.pro

Got the same message @trashkalmar

-keepnames class kotlinx.** { *; } did work though

[dtunctuncer]

I still have error even though I used suggested ProGuard rules

[djrsousa]

The suggested proguard rules should be enough. I mean:

# ServiceLoader support
-keepnames class kotlinx.coroutines.internal.MainDispatcherFactory {}
-keepnames class kotlinx.coroutines.CoroutineExceptionHandler {}

# Most of volatile fields are updated with AFU and should not be mangled
-keepclassmembernames class kotlinx.** {
    volatile <fields>;
}

I was recently facing this issue and realised that it was my fault and nothing to do with the proguard rules. Basically, we were re-signing the apk and removing the META-INF folder in the process. So, for the ones that are still facing the issue, please make sure that you are not doing the same (re-signing your apk and removing the META-INF folder after the release build is done). If that's the case, I would suggest you to generate an unsigned build and sign it afterwards.

Just for reference, I'm using the version 1.0.1.
implementation ("org.jetbrains.kotlinx:kotlinx-coroutines-android:1.0.1")

Hope it helps.

[josselinPello]

We were having this crash without even using ProGuard 😅 As mentioned by @djrsousa, it's because we were:

Signing the APK twice,

and replacing the META-INF folder in the process...

[endru-kargo]

In our case, we put signingConfigs in the gradle file, then use the Generate Signed Bundle / APK to create the bundle. :D
Removing the signingConfigs solves the problem.

[Panajev]

@djrsousa thanks for spelling out the issue so well. Wished I had seen it before spending extra time researching the issue, but it was a good experience nonetheless.
Your suggestions, or moving to letting your build.gradle specify how to sign the app in debug and release modes, work, but if people still want to follow their current re-signing flow, they could delete only few files in the META-INF folder instead of all the files:

zip -d "$apkInputFullPath" META-INF/\*.RSA
zip -d "$apkInputFullPath" META-INF/\*.SF
zip -d "$apkInputFullPath" META-INF/\*.MF

Unless I am missing something, this should do the trick and be a very minimal change to the script people might be already running. Those files are the only ones that get added / modified when the signing occurs from what we could see.

[skywalkerhbz]

We were having this crash without even using ProGuard 😅 As mentioned by @djrsousa, it's because we were:

Signing the APK twice,

and replacing the META-INF folder in the process...

How can i sign the apk twice,but just replace the signature files in the META-INF folder?
Please... this confused me some days....