-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implementation of a SLF4J MDC Context #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, I will follow this issue to see when it is integrated. |
a740ded
to
19ee038
Compare
@abendt A notable different of this PR from the original PR #403 is that when Even if you just do This is a design decision I'm not entirely sure of, though. It creates side effects to the all code by a simple fact of adding Another approach would be to only update thread's MDC is the coroutine has |
a83f4aa
to
149d9a2
Compare
a83e8cd
to
45f055f
Compare
Tests don't match our pattern |
@qwwdfsad I've updated test named and wrote more detailed docs for |
e7fb0e6
to
08b6ad5
Compare
Reworked #403, integrated with #454, see #119