Skip to content

implementation of a SLF4J MDC context #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

abendt
Copy link
Contributor

@abendt abendt commented Jun 20, 2018

We use the CoRoutines rxjava integration and stumbled across the necessity to make the SLF4J MDC Context within in the CoRoutine scope. We implemented a solution based on the the description here:
#119

@oshai
Copy link
Contributor

oshai commented Jun 29, 2018

In case this is merged will add it to kotlin-logging docs

@x0a1b
Copy link

x0a1b commented Jul 10, 2018

I think it's a really useful addition must have! But I would question it's existence here rather than in kotlin-logging.

@abendt
Copy link
Contributor Author

abendt commented Jul 10, 2018

fair enough, i created the PR here because of the suggestion of @elizarov: #119
kotlin-logging also looks like a reasonable location

@oshai
Copy link
Contributor

oshai commented Jul 10, 2018

I think that both here and in kotlin-logging this will be an integration module. @elizarov suggested: "We should really have it out-of-the box in a separate integration module." in #119 .
In addition, kotlinx.coroutines already has other integration modules that are similar so it seems like a more natural place to look for, and also a case for example for the lib users.

elizarov pushed a commit that referenced this pull request Jul 25, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Jul 25, 2018
See discussion in PR #403 and issue #119
@elizarov
Copy link
Contributor

I've rebased your code on top of new architecture to introduce thread-local context elements as explained in #119 and opened a new PR #455

@elizarov elizarov closed this Jul 25, 2018
elizarov pushed a commit that referenced this pull request Jul 25, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Jul 26, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 21, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 21, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 21, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 22, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 22, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 22, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 23, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 23, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 23, 2018
See discussion in PR #403 and issue #119
elizarov pushed a commit that referenced this pull request Aug 23, 2018
See discussion in PR #403 and issue #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants