Tweak Kover: improve coverage, disable deprecations, add missing test… #3161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
approved these changes
Feb 1, 2022
| // TODO compile against API 22+ so this can be invoked without reflection. | ||
| private val Message.isAsynchronous: Boolean | ||
| get() = Message::class.java.getDeclaredMethod("isAsynchronous").invoke(this) as Boolean | ||
| } |
There was a problem hiding this comment.
Historical note: this code was simply moved from HandlerDispatcherTest.
| } | ||
|
|
There was a problem hiding this comment.
Life hack: git diff --patience provides a sensible diff instead of this broken mess with methods broken in half. Alas, doesn't seem like there's a way to make Github use another diffing algorithm.
dee-tree
pushed a commit
to dee-tree/kotlinx.coroutines
that referenced
this pull request
Jul 21, 2022
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in slf4j
Addresses #3156