Skip to content

Investigate low coverage percantage of integration modules #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
qwwdfsad opened this issue Jan 25, 2022 · 2 comments
Closed
5 tasks done

Investigate low coverage percantage of integration modules #3156

qwwdfsad opened this issue Jan 25, 2022 · 2 comments
Assignees
@qwwdfsad
Labels
enhancement

Comments

@qwwdfsad
Copy link
Collaborator

qwwdfsad commented Jan 25, 2022 •
edited
Loading

  • android -- 50%
  • debug -- 84%
  • reactive and reactor -- 65%
  • rx2 (but not rx3) -- 78%
  • slf4j -- 81%
@qwwdfsad qwwdfsad self-assigned this Jan 25, 2022
@qwwdfsad
Copy link
Collaborator Author

Rx2 is mostly the victim of deprecated signatures (both with error and hidden) not being tested, I've reported it to intellij-coverage. Everything else seems to be quite okay -- toString, hashCode, various addSuppressed and last-ditch efforts e.g. when rx onError throws an exception

@qwwdfsad
Copy link
Collaborator Author

Reactor is prone mostly to same, reactive is fixed

qwwdfsad added a commit that referenced this issue Jan 26, 2022
@qwwdfsad
Tweak Kover: improve coverage, disable deprecations, add missing test…
930f52d 
… in slf4j

Addresses #3156
qwwdfsad added a commit that referenced this issue Jan 26, 2022
@qwwdfsad
Tweak Kover: improve coverage, disable deprecations, add missing test…
39c0318 
… in slf4j

Addresses #3156
@qwwdfsad qwwdfsad mentioned this issue Jan 26, 2022
Merged
qwwdfsad added a commit that referenced this issue Jan 27, 2022
@qwwdfsad
Test AndroidExceptionPreHandlerTest and awaitFrame in Adnroid module
38d3e51 
Addresses #3156
qwwdfsad added a commit that referenced this issue Feb 1, 2022
@qwwdfsad
Coverage: improve test coverage, disable deprecations, add missing te…
76989f7 
…st… (#3161)

Addresses #3156
dee-tree pushed a commit to dee-tree/kotlinx.coroutines that referenced this issue Jul 21, 2022
@qwwdfsad @dee-tree
Coverage: improve test coverage, disable deprecations, add missing te…
5c90cd7 
…st… (Kotlin#3161)

Addresses Kotlin#3156
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this issue Sep 14, 2022
@qwwdfsad @pablobaxter
Coverage: improve test coverage, disable deprecations, add missing te…
47331d5 
…st… (Kotlin#3161)

Addresses Kotlin#3156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qwwdfsad