Implemented copyForChildCoroutine() for ThreadContextElement
#2936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in place of directExecutor().
This should prevent successful casts to type SettableFuture, meaning client code can't access and complete the internal Future without resorting to reflection..
This allows contexts using non-copyable `ThreadContextElements` to inherit a reference-equal context without constructing a new one.
This allows contexts using non-copyable `ThreadContextElements` to inherit a reference-equal context without constructing a new one.
This allows contexts using non-copyable `ThreadContextElements` to inherit a reference-equal context without constructing a new one.
This allows contexts using non-copyable `ThreadContextElements` to inherit a reference-equal context without constructing a new one.
qwwdfsad
reviewed
Oct 11, 2021
| } | ||
| } | ||
|
|
||
| assertNotSame(inheritedElement, parentElement, |
There was a problem hiding this comment.
This test fails because you're adding CopyForChildCoroutineElement, but querying MyElement
| * Returns [this] if `this` has zero [CopyableThreadContextElement] in it. | ||
| */ | ||
| private fun CoroutineContext.foldCopiesForChildCoroutine(): CoroutineContext { | ||
| val jobElementCount = fold(0) { count, it -> |
There was a problem hiding this comment.
A bit faster and more compact implementation:
val hasToCopy = fold(false) { result, it ->
result || it is CopyableThreadContextElement<*>
}
| * A coroutine using this mechanism can safely call Java code that assumes it's called using a | ||
| * `Thread`. | ||
| */ | ||
| public interface CopyableThreadContextElement<S> : ThreadContextElement<S> { |
There was a problem hiding this comment.
Please mark it as @ExperimentalCoroutinesApi
… in a JSON format (Kotlin#2933)
…ate API (Kotlin#2922) * Mention CoroutineDispatcher.limitedParallelism as an intended replacement * Prepare the API to sharing with K/N new memory model where we _have_ to have this API Addresses Kotlin#2919
* Add version file to each module resources * The approach with "Specification-Version" in Manifest doesn't work because Android merges all JARs into a single resource, trimming all the manifests Fixes Kotlin#2941
…oroutineExceptionHandler (Kotlin#2840) This change makes `future` coroutine builder consistent with `java.util.concurrent.FutureTask` which also drops exceptions that happen after successful cancellation. Fixes Kotlin#2774 Fixes Kotlin#2791
* Update binary compatibility validator * Fix race in testFuturePropagatesExceptionToParentAfterCancellation
Change the build scripts and the file layout so that kotlinx-coroutines-test is built on all platforms.
* transformWhile * awaitClose and ProducerScope (for callbackFlow and channelFlow) * merge * runningFold, runningReduce, and scan
….IO unbounded for limited parallelism (Kotlin#2918) * Introduce CoroutineDispatcher.limitedParallelism for granular concurrency control * Elastic Dispatchers.IO: * Extract Ktor-obsolete API to a separate file for backwards compatibility * Make Dispatchers.IO being a slice of unlimited blocking scheduler * Make Dispatchers.IO.limitParallelism take slices from the same internal scheduler Fixes Kotlin#2943 Fixes Kotlin#2919
…Kotlin#2957) * Eagerly load CoroutineExceptionHandler and load the corresponding service Partially addresses Kotlin#2552
…ine()`. This is a `ThreadContextElement` that is copy-constructed when a new coroutine is created and inherits the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2839.
I've implemented this twice. In the first diff by adding
fun copyForChildCoroutine() = thisdirectly toThreadContextElement. In the second diff by creating a subtype:Using a subtype avoids creating a new
CoroutineContexton launch for contexts that contain non-copyableThreadContextElements. This is cheaper, but more importantly, it's backwards-compatible forcoroutineContextreference equality for anyCoroutineContextthat usesThreadContextElement. Directly adding this toThreadContextElementis a subtle breaking change. I prefer the subtype implementation, but either works for me.