coroutines-test as an MPP #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
commented
Oct 1, 2021
| @@ -56,12 +56,11 @@ public final class kotlinx/coroutines/test/TestDispatchers { | |||
| } | |||
|
|
|||
| public abstract interface class kotlinx/coroutines/test/UncaughtExceptionCaptor { | |||
| public abstract fun cleanupTestCoroutines ()V | |||
| public abstract fun cleanupTestCoroutinesCaptor ()V | |||
There was a problem hiding this comment.
Without this rename, JS IR compiler just fails, and the native compiler complains
Member inherits different @Throws filters from UncaughtExceptionCaptor, DelayController
There was a problem hiding this comment.
Worth reporting, because JS IR should ignore @Throws
qwwdfsad
approved these changes
Oct 6, 2021
| @@ -56,12 +56,11 @@ public final class kotlinx/coroutines/test/TestDispatchers { | |||
| } | |||
|
|
|||
| public abstract interface class kotlinx/coroutines/test/UncaughtExceptionCaptor { | |||
| public abstract fun cleanupTestCoroutines ()V | |||
| public abstract fun cleanupTestCoroutinesCaptor ()V | |||
There was a problem hiding this comment.
Worth reporting, because JS IR should ignore @Throws
qwwdfsad
approved these changes
Oct 7, 2021
dkhalanskyjb
force-pushed
the
coroutines-test-multiplatform
branch
from
0e62052 to
78e76b3
Compare
yorickhenning
pushed a commit
to yorickhenning/kotlinx.coroutines
that referenced
this pull request
Oct 14, 2021
Change the build scripts and the file layout so that kotlinx-coroutines-test is built on all platforms.
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Change the build scripts and the file layout so that kotlinx-coroutines-test is built on all platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shouldn't change any behavior and instead only ensures that the test module can be built for all platforms. As is, it already requires introducing incompatibility, but, luckily, mostly in the interfaces that we decided to deprecate anyway.
Dispatchers.setMainisn't implemented for any targets other than JVM, all the other functionality seems to have been ported fine.