Fix the coroutine debugger in the IDE #2694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2461 introduced a problem where the coroutine debugger in the IDE would crash: #2690 According to @nikita-nazarov, the coroutine debugger crashes at a point where a stack trace is already available and the IDE plugin attempts to look up every class listed in the stack trace. The new classes listed in the artificial stack frames were never loaded, as only their names were accessed. Now, we force these classes to be loaded, and it seems like the crash disappears.
|
A problem this has compared to 1.4.3 is that the coroutine creation stack traces are displayed by the IDE in a broken manner: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2461 introduced a problem where the coroutine debugger in the IDE would crash.
According to @nikita-nazarov, the coroutine debugger crashes at a point where a stack trace is already available and the IDE plugin attempts to look up every class listed in the stack trace.
The new classes listed in the artificial stack frames were never loaded, as only their names were accessed. Now, we force these classes to be loaded at the point where
DebugProbesImplis, and it seems like the crash disappears.Fixes #2690