Display artificial stack frames as calls to functions instead of text #2461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Dec 28, 2020
| import kotlinx.coroutines.* | ||
|
|
||
| /** | ||
| * A collection of artificial stack trace elements to be included in stack traces by the coroutines machinery. |
There was a problem hiding this comment.
We can slightly improve this documentation: mention that it is for debugging purposes only and leave links to to the debug mode document and the corresponding property
dkhalanskyjb
force-pushed
the
no-backspace-in-traces
branch
2 times, most recently
from
8807021 to
06ca058
Compare
dkhalanskyjb
force-pushed
the
no-backspace-in-traces
branch
from
06ca058 to
3bd0554
Compare
|
I tested IDE navigation in this program: https://github.com/dkhalanskyjb/testRepo/tree/check-stacktrace-navigation. I couldn't make it break and can't imagine a reason for the current solution to fail. Though the namespace pollution does worry me, it is the case that at the time when the sources for a dependency are not yet downloaded, IDE is unable to determine where |
qwwdfsad
requested changes
Mar 24, 2021
dkhalanskyjb
force-pushed
the
no-backspace-in-traces
branch
from
119e84a to
806c67c
Compare
dkhalanskyjb
force-pushed
the
no-backspace-in-traces
branch
from
806c67c to
619d262
Compare
dkhalanskyjb
added a commit
that referenced
this pull request
May 11, 2021
#2461 introduced a problem where the coroutine debugger in the IDE would crash: #2690 According to @nikita-nazarov, the coroutine debugger crashes at a point where a stack trace is already available and the IDE plugin attempts to look up every class listed in the stack trace. The new classes listed in the artificial stack frames were never loaded, as only their names were accessed. Now, we force these classes to be loaded, and it seems like the crash disappears.
This was referenced May 11, 2021
dkhalanskyjb
added a commit
that referenced
this pull request
Dec 8, 2021
dkhalanskyjb
added a commit
that referenced
this pull request
Sep 9, 2022
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
dkhalanskyjb
added a commit
that referenced
this pull request
Oct 14, 2022
dkhalanskyjb
added a commit
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2291