-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add awaitCancellation() #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add awaitCancellation() #2225
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aa2c17d
Add awaitCancellation()
LouisCAD 6e692f5
Move awaitCancellation from Await.kt to Delay.kt
LouisCAD 4e139ce
Mention awaitCancellation in the Kdoc of delay
LouisCAD 87cb68e
Add usage examples to awaitCancellation()
LouisCAD ed52823
Mention awaitCancellation in the Kdoc of delay
LouisCAD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
kotlinx-coroutines-core/common/test/AwaitCancellationTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Copyright 2016-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
package kotlinx.coroutines | ||
|
||
import kotlin.test.* | ||
|
||
class AwaitCancellationTest : TestBase() { | ||
|
||
@Test | ||
fun testCancellation() = runTest(expected = { it is CancellationException }) { | ||
expect(1) | ||
coroutineScope { | ||
val deferred: Deferred<Nothing> = async { | ||
expect(2) | ||
awaitCancellation() | ||
} | ||
yield() | ||
expect(3) | ||
require(deferred.isActive) | ||
deferred.cancel() | ||
finish(4) | ||
deferred.await() | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it would be great to show some small practical example here, if you have one in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two examples. I failed to find simpler examples for now, but it's not public API so it can be changed in the future.
Also, I know
trySend
doesn't exist yet, but I thought it would look nicer thanrunCatching { offer(…) }
or a try/catch.