Add awaitCancellation() #2225
Closed
Add awaitCancellation() #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue Kotlin#2213
elizarov
suggested changes
Sep 8, 2020
| /** | ||
| * Suspends until cancellation, in which case it will throw a [CancellationException]. | ||
| * | ||
| * Handy because it returns [Nothing], allowing it to be used in any coroutine, |
There was a problem hiding this comment.
Actually, it would be great to show some small practical example here, if you have one in mind.
There was a problem hiding this comment.
Added two examples. I failed to find simpler examples for now, but it's not public API so it can be changed in the future.
Also, I know trySend doesn't exist yet, but I thought it would look nicer than runCatching { offer(…) } or a try/catch.
elizarov
approved these changes
Sep 14, 2020
|
Merged. |
elizarov
pushed a commit
that referenced
this pull request
Sep 14, 2020
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure about the relevance of the test and I couldn't run it on the JVM locally (because of #2224), but it succeeded in native (macosX64).
Feel free to make any suggestion regarding the files where the new code is, or suggest/perform edits to the doc.
Resolves #2213